fix #19580; add warning for bare except: clause #21099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menduist
reviewed
Dec 14, 2022
ringabout
commented
Dec 14, 2022
ringabout
commented
Dec 14, 2022
ringabout
commented
Dec 14, 2022
ringabout
commented
Dec 14, 2022
arnetheduck
reviewed
Dec 14, 2022
ringabout
commented
Dec 14, 2022
Co-authored-by: Jacek Sieka <arnetheduck@gmail.com>
ringabout
commented
Dec 15, 2022
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
bung87
reviewed
Dec 15, 2022
| while t.kind == tyObject: | ||
| if t.sym != nil and t.sym.owner != nil and | ||
| sfSystemModule in t.sym.owner.flags and | ||
| (t.sym.name.s == "Defect" or |
There was a problem hiding this comment.
s.name.id == getIdent(c.graph.cache, "Defect").id better avoiding string comparation ?
|
@narimiran can we backport pls? |
narimiran
pushed a commit
that referenced
this pull request
Dec 15, 2022
* fix #19580; add warning for bare except: clause * fixes some easy ones * Update doc/manual.md * fixes docs * Update changelog.md * addition * Apply suggestions from code review Co-authored-by: Jacek Sieka <arnetheduck@gmail.com> * Update doc/tut2.md Co-authored-by: Jacek Sieka <arnetheduck@gmail.com> (cherry picked from commit 91ce8c3)
Done! |
|
Look like the backport broke 1-6 :/ Maybe just remove the |
Done! |
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
* fix nim-lang#19580; add warning for bare except: clause * fixes some easy ones * Update doc/manual.md * fixes docs * Update changelog.md * addition * Apply suggestions from code review Co-authored-by: Jacek Sieka <arnetheduck@gmail.com> * Update doc/tut2.md Co-authored-by: Jacek Sieka <arnetheduck@gmail.com>
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* fix nim-lang#19580; add warning for bare except: clause * fixes some easy ones * Update doc/manual.md * fixes docs * Update changelog.md * addition * Apply suggestions from code review Co-authored-by: Jacek Sieka <arnetheduck@gmail.com> * Update doc/tut2.md Co-authored-by: Jacek Sieka <arnetheduck@gmail.com>
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
* fix nim-lang#19580; add warning for bare except: clause * fixes some easy ones * Update doc/manual.md * fixes docs * Update changelog.md * addition * Apply suggestions from code review Co-authored-by: Jacek Sieka <arnetheduck@gmail.com> * Update doc/tut2.md Co-authored-by: Jacek Sieka <arnetheduck@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #19580
supersedes #19582